Post-attribute ports cleanup pt. 1 by JonathanBrouwer · Pull Request #154808 · rust-lang/rust

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.3%, secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	3.0%	[1.8%, 4.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.2%, -1.9%]	3
All ❌✅ (primary)	1.3%	[1.3%, 1.3%]	1

Cycles

Results (secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.3%	[3.0%, 7.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-3.3%, -2.5%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	56
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	25
All ❌✅ (primary)	-0.1%	[-0.1%, -0.0%]	56

Bootstrap: 489.285s -> 487.19s (-0.43%)
Artifact size: 395.03 MiB -> 394.99 MiB (-0.01%)

JonathanBrouwer · 2026-04-05T06:26:08Z

That's just noise :)

compiler/rustc_attr_parsing/src/validate_attr.rs

jdonszelmann

Some small things, but in general: damn I'm so happy to see this. Been waiting a year an a half to do this. Thanks to everyone who joined the effort to get to this point, and thanks Jonathan for finally starting The Big Clean Up ™️

View changes since this review

jdonszelmann · 2026-04-05T07:51:04Z

compiler/rustc_expand/src/module.rs

        // `TyCtxt::check_mod_attrs`), but by the time that runs the macro
        // is expanded, and it doesn't give an error.
-        validate_attr::emit_fatal_malformed_builtin_attribute(&sess.psess, first_path, sym::path);
+        emit_malformed_attribute(&sess.psess, first_path.style, first_path.span, sym::path, template!(


this should maybe also be a parsed attribute 🤔

Agreed, I tried to make it one but then discovered #154781, so it is blocked on that

compiler/rustc_feature/src/builtin_attrs.rs

rustbot · 2026-04-05T07:57:40Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

JonathanBrouwer · 2026-04-05T09:37:15Z

@rustbot ready

jdonszelmann · 2026-04-05T10:05:14Z

@bors r+

rust-bors · 2026-04-05T10:05:18Z

📌 Commit 6927e64 has been approved by jdonszelmann

It is now in the queue for this repository.

JonathanBrouwer · 2026-04-05T10:06:38Z

@bors rollup
The perf result is noise

@jdonszelmann

…onszelmann Post-attribute ports cleanup pt. 1 r? @jdonszelmann This cleans up some checks I could find were for non-parsed attributes, and works towards removing BUILTIN_ATTRIBUTES All commits do one thing and every commit passes tests, so best reviewed commit by commit

…uwer Rollup of 3 pull requests Successful merges: - #154657 (Fix pattern assignment suggestions for uninitialized bindings) - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message) - #154808 (Post-attribute ports cleanup pt. 1)

@jdonszelmann

…onszelmann Post-attribute ports cleanup pt. 1 r? @jdonszelmann This cleans up some checks I could find were for non-parsed attributes, and works towards removing BUILTIN_ATTRIBUTES All commits do one thing and every commit passes tests, so best reviewed commit by commit

…uwer Rollup of 8 pull requests Successful merges: - #153440 (Various LTO cleanups) - #154561 (Suggest similar keyword when visibility is not followed by an item) - #154657 (Fix pattern assignment suggestions for uninitialized bindings) - #154717 (Fix ICE in unsafe binder discriminant helpers) - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message) - #154808 (Post-attribute ports cleanup pt. 1) - #154849 (Promote `char::is_case_ignorable` from perma-unstable to unstable) - #154850 (ast_validation: scalable vectors okay for rustdoc)

JonathanBrouwer · 2026-04-06T04:02:49Z

@bors try jobs=i686-msvc-2

rust-bors · 2026-04-06T04:02:54Z

⌛ Trying commit 6927e64 with merge e5ceaf0…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/24018143988

Post-attribute ports cleanup pt. 1 try-job: i686-msvc-2

JonathanBrouwer · 2026-04-06T06:29:11Z

@bors r-
Causes the try job to hang

[NO MERGE] Debug PR for #154808 try-job: i686-mscv-2

[NO MERGE] Debug PR for #154808 try-job: i686-msvc-2

rust-bors · 2026-04-06T10:05:25Z

💥 Test timed out after 21600s

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 4, 2026

rustbot assigned jdonszelmann Apr 4, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Apr 4, 2026

Auto merge of #154808 - JonathanBrouwer:attr_cleanup, r=<try>

643c6fe

Post-attribute ports cleanup pt. 1

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 4, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Apr 4, 2026

Auto merge of #154808 - JonathanBrouwer:attr_cleanup, r=<try>

80c2a26

Post-attribute ports cleanup pt. 1

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 5, 2026

jdonszelmann reviewed Apr 5, 2026

View reviewed changes

compiler/rustc_attr_parsing/src/validate_attr.rs Outdated Show resolved Hide resolved

jdonszelmann requested changes Apr 5, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2026

JonathanBrouwer force-pushed the attr_cleanup branch from bd51105 to d23c724 Compare April 5, 2026 09:36

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 5, 2026

Simplify attribute validation

c324d6e

JonathanBrouwer added 5 commits April 5, 2026 11:57

Remove EncodeCrossCrate from BUILTIN_ATTRIBUTES

f967bf3

Remove AttributeDuplicates from BUILTIN_ATTRIBUTES

eecf63c

Remove AttributeType from BUILTIN_ATTRIBUTES

9058b5f

Remove AttributeSafety from BUILTIN_ATTRIBUTES

c7f99c4

Remove unused attribute check for unparsed builtin attributes

6927e64

JonathanBrouwer force-pushed the attr_cleanup branch from d23c724 to 6927e64 Compare April 5, 2026 09:57

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2026

JonathanBrouwer mentioned this pull request Apr 5, 2026

Rollup of 3 pull requests #154845

Closed

JonathanBrouwer mentioned this pull request Apr 5, 2026

Rollup of 8 pull requests #154855

Closed

rust-bors bot pushed a commit that referenced this pull request Apr 6, 2026

Auto merge of #154808 - JonathanBrouwer:attr_cleanup, r=<try>

e5ceaf0

Post-attribute ports cleanup pt. 1 try-job: i686-msvc-2

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 6, 2026

JonathanBrouwer mentioned this pull request Apr 6, 2026

[NO MERGE] Debug PR for #154808 #154873

Draft

rust-bors bot pushed a commit that referenced this pull request Apr 6, 2026

Auto merge of #154873 - JonathanBrouwer:attr_cleanup_debug, r=<try>

da35851

[NO MERGE] Debug PR for #154808 try-job: i686-mscv-2

rust-bors bot pushed a commit that referenced this pull request Apr 6, 2026

Auto merge of #154873 - JonathanBrouwer:attr_cleanup_debug, r=<try>

a49748b

[NO MERGE] Debug PR for #154808 try-job: i686-msvc-2

rust-bors bot pushed a commit that referenced this pull request Apr 6, 2026

Auto merge of #154873 - JonathanBrouwer:attr_cleanup_debug, r=<try>

e07e6fd

[NO MERGE] Debug PR for #154808 try-job: i686-msvc-2

Uh oh!

Conversation

JonathanBrouwer commented Apr 4, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 4, 2026

Uh oh!

Bryntet commented Apr 4, 2026

Uh oh!

JonathanBrouwer commented Apr 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

JonathanBrouwer commented Apr 4, 2026

Uh oh!

rust-bors bot commented Apr 4, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 4, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Apr 5, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Apr 5, 2026

Uh oh!

Uh oh!

jdonszelmann left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Apr 5, 2026

Uh oh!

JonathanBrouwer commented Apr 5, 2026

Uh oh!

jdonszelmann commented Apr 5, 2026

Uh oh!

rust-bors bot commented Apr 5, 2026

Uh oh!

JonathanBrouwer commented Apr 5, 2026

Uh oh!

JonathanBrouwer commented Apr 6, 2026

Uh oh!

rust-bors bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Apr 6, 2026

Uh oh!

rust-bors bot commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JonathanBrouwer commented Apr 4, 2026 •

edited by rustbot

Loading

jdonszelmann left a comment •

edited by rustbot

Loading

rust-bors bot commented Apr 6, 2026 •

edited

Loading