Replace the spdx-rs dependency with a minimal in-tree SPDX tag-value parser#154823
Open
jakubadamw wants to merge 1 commit intorust-lang:mainfrom
Open
Replace the spdx-rs dependency with a minimal in-tree SPDX tag-value parser#154823jakubadamw wants to merge 1 commit intorust-lang:mainfrom
jakubadamw wants to merge 1 commit intorust-lang:mainfrom
Conversation
…parser The spdx-rs crate is no longer maintained and is behind on its own dependency updates. The only function that collect-license-metadata uses from it is `spdx_rs::parsers::spdx_from_tag_value`, which parses the output of the `reuse` tool to extract file names, licences and copyright text. Replace this with a small minimal parser that handles just the subset of the SPDX tag-value format that is needed: `Tag: Value` line pairs and multi-line `<text>...</text>` blocks. Coincidentally, this gets rid of the last transitive dependency on syn v1.
Collaborator
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spdx-rs crate is no longer maintained and is behind on its own dependency updates. It is currently used in the collect-license-metadata, which currently uses a single function therefrom:
spdx_rs::parsers::spdx_from_tag_value, which parses the output of thereusetool to extract file names, licences and copyright text.This PR replaces the use of said function with a small minimal parser that handles just the subset of the SPDX tag-value format that is needed:
Tag: Valueline pairs and multi-line<text>...</text>blocks.Coincidentally, this gets rid of the last transitive dependency on syn v1.