Skip to content

Ensure Send/Sync impl for std::process::CommandArgs #155113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Mark-Simulacrum wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Draft

Ensure Send/Sync impl for std::process::CommandArgs #155113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions library/std/src/process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,6 +1296,12 @@ impl<'a> ExactSizeIterator for CommandArgs<'a> {
}
}

const fn assert_send<T: core::marker::Send>() {}
const fn assert_sync<T: core::marker::Sync>() {}

const _: () = assert_send::<CommandArgs<'static>>();
const _: () = assert_sync::<CommandArgs<'static>>();

/// An iterator over the command environment variables.
///
/// This struct is created by
Expand Down
5 changes: 5 additions & 0 deletions library/std/src/sys/process/unix/common/cstring_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ pub struct CStringIter<'a> {
iter: crate::slice::Iter<'a, *const c_char>,
}

// SAFETY: `CStringIter` is basically just a `slice::Iter<&'a CStr>`
unsafe impl Send for CStringIter<'_> {}
// SAFETY: `CStringIter` is basically just a `slice::Iter<&'a CStr>`
unsafe impl Sync for CStringIter<'_> {}

impl<'a> Iterator for CStringIter<'a> {
type Item = &'a CStr;
fn next(&mut self) -> Option<&'a CStr> {
Expand Down
Loading