add regression test for OpenOptionsExt downstream compat#155140
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 13, 2026
Merged
add regression test for OpenOptionsExt downstream compat#155140rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @jdonszelmann. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Kivooeo
reviewed
Apr 11, 2026
| //@ only-windows | ||
| //@ check-pass | ||
|
|
||
| // Regression test for #153486. |
Member
There was a problem hiding this comment.
use a link instead of just issue number
Contributor
|
Other than kivoos suggestions, r=me |
Vastargazing
force-pushed
the
open-options-ext-test
branch
from
3487ad1 to
de2d5b6
Compare
Contributor
|
@bors r=jdonszelmann,kivooeo |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 11, 2026
…lmann,kivooeo add regression test for OpenOptionsExt downstream compat Following up on #153491, which added a warning comment there, but no automated guardrail to prevent another breaking change like #149718 This adds a simple windows-only ui test that manually implements `OpenOptionsExt`. That way, if someone accidentally adds another required method to the trait, we catch it before it reaches stable and breaks downstream crates like Tokio again. Closes #153486
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
S-waiting-on-review
Contributor
|
💔 Test for 62f98ce failed: CI. Failed job:
|
Vastargazing
force-pushed
the
open-options-ext-test
branch
from
de2d5b6 to
f9b6718
Compare
rust-bors
bot
added
S-waiting-on-author
Contributor
|
@bors r=jdonszelmann,kivooeo |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 13, 2026
…, r=jdonszelmann,kivooeo add regression test for OpenOptionsExt downstream compat Following up on rust-lang#153491, which added a warning comment there, but no automated guardrail to prevent another breaking change like rust-lang#149718 This adds a simple windows-only ui test that manually implements `OpenOptionsExt`. That way, if someone accidentally adds another required method to the trait, we catch it before it reaches stable and breaks downstream crates like Tokio again. Closes rust-lang#153486
This was referenced Apr 13, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
…uwer Rollup of 10 pull requests Successful merges: - #155227 (`rust-analyzer` subtree update) - #153335 (Add #![unstable_removed(..)] attribute to track removed features) - #154932 (Handle RTN projections in assoc type restriction diagnostics) - #155096 (delegation: support proper interaction of user-specified args and impl Traits) - #155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`) - #155140 (add regression test for OpenOptionsExt downstream compat) - #155182 (Make the expansion of guard metavars begin guard non-terminals) - #155226 (delegation: revert execution of hir_crate_items before delayed lowering) - #153997 (Use closures more consistently in `dep_graph.rs`.) - #155003 (update thin-vec)
rust-timer
added a commit
that referenced
this pull request
Apr 13, 2026
Rollup merge of #155140 - Vastargazing:open-options-ext-test, r=jdonszelmann,kivooeo add regression test for OpenOptionsExt downstream compat Following up on #153491, which added a warning comment there, but no automated guardrail to prevent another breaking change like #149718 This adds a simple windows-only ui test that manually implements `OpenOptionsExt`. That way, if someone accidentally adds another required method to the trait, we catch it before it reaches stable and breaks downstream crates like Tokio again. Closes #153486
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Apr 13, 2026
…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#155227 (`rust-analyzer` subtree update) - rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features) - rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics) - rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits) - rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`) - rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat) - rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals) - rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering) - rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.) - rust-lang/rust#155003 (update thin-vec)
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Apr 16, 2026
…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#155227 (`rust-analyzer` subtree update) - rust-lang/rust#153335 (Add #![unstable_removed(..)] attribute to track removed features) - rust-lang/rust#154932 (Handle RTN projections in assoc type restriction diagnostics) - rust-lang/rust#155096 (delegation: support proper interaction of user-specified args and impl Traits) - rust-lang/rust#155106 (cg_llvm: scalable vectors with `simd_cast` and `simd_select`) - rust-lang/rust#155140 (add regression test for OpenOptionsExt downstream compat) - rust-lang/rust#155182 (Make the expansion of guard metavars begin guard non-terminals) - rust-lang/rust#155226 (delegation: revert execution of hir_crate_items before delayed lowering) - rust-lang/rust#153997 (Use closures more consistently in `dep_graph.rs`.) - rust-lang/rust#155003 (update thin-vec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #153491, which added a warning comment there, but no automated guardrail to prevent another breaking change like #149718
This adds a simple windows-only ui test that manually implements
OpenOptionsExt. That way, if someone accidentally adds another required method to the trait, we catch it before it reaches stable and breaks downstream crates like Tokio again.Closes #153486