Rollup of 3 pull requests by jhpratt · Pull Request #155141 · rust-lang/rust

jhpratt · 2026-04-11T05:49:14Z

Successful merges:

Semantic checks of impl restrictions #154661 (Semantic checks of impl restrictions)
Suggest similar target names on unrecognized --target #155132 (Suggest similar target names on unrecognized --target)
Tweak comment about intrinsics in cross-crate-inlinable #155136 (Tweak comment about intrinsics in cross-crate-inlinable)

@Urgau

…eck, r=jhpratt,Urgau Semantic checks of `impl` restrictions This PR implements semantic checks for `impl` restrictions proposed in the [Restrictions RFC](https://rust-lang.github.io/rfcs/3323-restrictions.html) (Tracking Issue rust-lang#105077), and linked to a [GSOC idea/proposal](https://github.com/rust-lang/google-summer-of-code/tree/142433eb3b104b2f32bae0b9dfafb78a0a2ac579?tab=readme-ov-file#implementing-impl-and-mut-restrictions). It lowers the resolved paths of `impl` restrictions from the AST to HIR and into `TraitDef`, and integrates the checks into the coherence phase by extending `check_impl`. As parsing (rust-lang#152943) and path resolution (rust-lang#153556) have already been implemented, this PR provides a working implementation of `impl` restrictions. r? @Urgau cc @jhpratt

…t-on-unrecognized-155085, r=Kivooeo Suggest similar target names on unrecognized `--target` When an unrecognized `--target` is passed check the list of available targets and suggest the closest matching built-in target as a help message. ### Before ``` error: error loading target specification: could not find specification for target "x86_64-linux-gnu" = help: run `rustc --print target-list` for a list of built-in targets ``` ### After ``` error: error loading target specification: could not find specification for target "x86_64-linux-gnu" = help: run `rustc --print target-list` for a list of built-in targets = help: did you mean `x86_64-unknown-linux-gnu`? ``` Regarding the expected test case in rust-lang#155085 (comment) the `edit_distance_with_substrings` was used over `edit_distance` because in the case of `x86_64-linux-gnu` the `edit_distance` would return `x86_64-linux-android` instead of `x86_64-unknown-linux-gnu` rust-lang#155085

@RalfJung

…wesleywiser Tweak comment about intrinsics in cross-crate-inlinable @RalfJung pointed out that the previous comment is technically wrong: rust-lang#145910 (comment)

jhpratt · 2026-04-11T05:49:23Z

@bors r+ rollup=never p=5

rust-bors · 2026-04-11T05:49:27Z

📌 Commit bb74525 has been approved by jhpratt

It is now in the queue for this repository.

rust-bors · 2026-04-11T09:02:36Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 12m 56s
Pushing c29effd to main...

rust-timer · 2026-04-11T09:03:30Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#154661	Semantic checks of `impl` restrictions	`f87423c19a5c1f0a92c18b796e759387e28d2a4d` (link)
#155132	Suggest similar target names on unrecognized `--target`	`1d7304f18a0848b67213f3684006e80b859e7460` (link)
#155136	Tweak comment about intrinsics in cross-crate-inlinable	`97dde1f0646e0c6751cac4b083fc86251303d6f1` (link)

previous master: c7c14d4fb0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-04-11T09:06:00Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c7c14d4 (parent) -> c29effd (this PR)

Test differences

Show 10 test diffs

Stage 1

[ui] tests/ui/errors/unknown-target-suggestion.rs: [missing] -> pass (J1)
[ui] tests/ui/impl-restriction/impl-restriction-check.rs#e2015: [missing] -> pass (J1)
[ui] tests/ui/impl-restriction/impl-restriction-check.rs#e2018: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/errors/unknown-target-suggestion.rs: [missing] -> pass (J0)
[ui] tests/ui/impl-restriction/impl-restriction-check.rs#e2015: [missing] -> pass (J0)
[ui] tests/ui/impl-restriction/impl-restriction-check.rs#e2018: [missing] -> pass (J0)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c29effdf79bdea928ea366a2a820ed15c1de5f43 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 2h 30m -> 1h 51m (-25.6%)
dist-x86_64-apple: 2h 15m -> 1h 48m (-19.9%)
dist-x86_64-musl: 2h 9m -> 1h 45m (-18.5%)
dist-x86_64-llvm-mingw: 1h 43m -> 1h 59m (+14.6%)
aarch64-apple: 3h 15m -> 2h 47m (-14.0%)
x86_64-msvc-ext2: 1h 58m -> 1h 44m (-11.6%)
x86_64-msvc-1: 2h 39m -> 2h 21m (-11.1%)
x86_64-msvc-ext3: 1h 44m -> 1h 55m (+9.6%)
x86_64-gnu-gcc: 1h 12m -> 1h 6m (-8.3%)
aarch64-gnu-llvm-21-1: 1h 3m -> 58m 29s (-7.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-04-11T09:44:18Z

Finished benchmarking commit (c29effd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (primary 10.1%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	11.1%	[3.3%, 25.8%]	13
Regressions ❌ (secondary)	4.5%	[2.7%, 8.7%]	4
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	10.1%	[-2.4%, 25.8%]	14

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.09s -> 491.148s (0.22%)
Artifact size: 394.19 MiB -> 394.19 MiB (-0.00%)

CoCo-Japan-pan and others added 18 commits April 1, 2026 12:01

Lower impl restriction to HIR

d5c756a

Intravisit hir::ImplRestriction

01793db

Lower impl restriction information to TraitDef

bda0fce

Emit error in implementation of restricted trait

cdbccf7

Add UI tests for semantic checks of impl restrictions

222292a

Call visit_path_segment directly

159f1f2

Remove shorthand from HIR

5863660

Remove the type alias for Path<'hir, DefId>

4f12609

Add a FIXME for rustdoc handling impl restrictions

65effbf

Modify restriction_path

2f400de

Add non-ancestor errors involving restrictions to other crates

6f97273

Inline krate

72c1d65

Display only crate name for external trait impl restrictions

46befd8

Suggest similar target names on unrecognized --target

1137762

Tweak comment about intrinsics in cross-crate-inlinable

270ebfc

Rollup merge of rust-lang#155136 - saethlin:intrinsic-cci-comment, r=…

bb74525

…wesleywiser Tweak comment about intrinsics in cross-crate-inlinable @RalfJung pointed out that the previous comment is technically wrong: rust-lang#145910 (comment)

rust-bors bot added the rollup A PR which is a rollup label Apr 11, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Apr 11, 2026

rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 11, 2026

rust-bors bot merged commit c29effd into rust-lang:main Apr 11, 2026
12 checks passed

rustbot added this to the 1.97.0 milestone Apr 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 3 pull requests#155141

Rollup of 3 pull requests#155141
rust-bors[bot] merged 18 commits intorust-lang:mainfrom
jhpratt:rollup-pjDewx9

jhpratt commented Apr 11, 2026

Uh oh!

jhpratt commented Apr 11, 2026

Uh oh!

rust-bors bot commented Apr 11, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 11, 2026

Uh oh!

Uh oh!

rust-timer commented Apr 11, 2026

Uh oh!

github-actions bot commented Apr 11, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

jhpratt commented Apr 11, 2026

Uh oh!

jhpratt commented Apr 11, 2026

Uh oh!

rust-bors bot commented Apr 11, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 11, 2026

Uh oh!

Uh oh!

rust-timer commented Apr 11, 2026

Uh oh!

github-actions bot commented Apr 11, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Apr 11, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants