Use weak linkage for EII defaults#157311
Open
jdonszelmann wants to merge 1 commit into
Open
Conversation
rustbot
added
A-attributes
Member
|
To repeat what I said in private, the LLVM docs seem to suggest that linkonce allows discarding definitions if they aren't referenced in the same object file, but there doesn't currently seem to be any place that distinguishes linkonce and weak in LLVM other than spirv that I could find. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hard to find a test for this, but weak seems more correct (after private discussion with @bjorn3)
Also changes a log statement to make it a lil easier to see what's going on.
r? @bjorn3