Make Literal::byte_character_value work with bytes as well#157338
Open
GuillaumeGomez wants to merge 2 commits into
Open
Make Literal::byte_character_value work with bytes as well#157338GuillaumeGomez wants to merge 2 commits into
Literal::byte_character_value work with bytes as well#157338GuillaumeGomez wants to merge 2 commits into
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Just realized the failure is because of the GCC backend. Not sure why, gonna ignore this test for now for the GCC backend. |
GuillaumeGomez
force-pushed
the
byte_character_value
branch
from
22e7e40 to
d6ee541
Compare
Member
Author
|
CI is happy now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in this comment,
byte_character_valueshould work for bytes, so this PR fixes it.r? @traviscross