Implement new gdb/lldb pretty-printers#60826
Closed
artemmukhin wants to merge 2 commits intorust-lang:masterfrom
Closed
Implement new gdb/lldb pretty-printers#60826artemmukhin wants to merge 2 commits intorust-lang:masterfrom
artemmukhin wants to merge 2 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces current gdb and lldb pretty-printers with new ones which were originally written for IntelliJ Rust.
The current state of lldb pretty-printers is poor, because they don't use synthetic children. When I started to reimplement lldb pretty-printers with synthetic children support, I've found current version strange and hard to support. I think
debugger_pretty_printers_common.pyis overkill, so I got rid of it.The new pretty-printers have to support all types supported by current pretty-printers, and also support
Rc,Arc,Cell,Ref,RefCell,RefMut,HashMap,HashSet.Fixes #56252