rustc: move mir::SourceScopeLocalData to a field of SourceScopeData.#66789
Merged
bors merged 3 commits intorust-lang:masterfrom Dec 2, 2019
Merged
rustc: move mir::SourceScopeLocalData to a field of SourceScopeData.#66789bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By having one
ClearCrossCrate<SourceScopeLocalData>for each scope, as opposed to a singleClearCrossCratefor all theSourceScopeLocalDatas, we can represent the fact that some scopes haveSourceScopeLocalDataassociated with them, and some don't.This is useful when doing MIR inlining across crates, because the
ClearCrossCratewill beClearfor the cross-crate MIR scopes andSetfor the local ones.Also see #66203 (comment) for some context around this approach.
Fixes #51314.