Skip to content

Miri: unleash all feature gates#71631

Merged
bors merged 10 commits intorust-lang:masterfrom
RalfJung:miri-unleash-the-gates
May 4, 2020
Merged

Miri: unleash all feature gates#71631
bors merged 10 commits intorust-lang:masterfrom
RalfJung:miri-unleash-the-gates

Conversation

@RalfJung
Copy link
Copy Markdown
Member

IMO it is silly to unleash features that do not even have a feature gate yet, but not unleash features that do. The only thing this achieves is making unleashed mode annoying to use as we have to figure out the feature flags to enable (and not always do the error messages say what that flag is).

Given that the point of -Z unleash-the-miri-inside-of-you is to debug the Miri internals, I see no good reason for this extra hurdle. I cannot imagine a situation where we'd use that flag, realize the program also requires some feature gate, and then be like "oh I guess if this feature is unstable I will do something else". Instead, we'll always just add that flag to the code as well, so requiring the flag achieves nothing.

r? @oli-obk @ecstatic-morse
Fixes #71630

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Miri does not get entirely unleashed

5 participants