Add optional half crate support for ScalarOperand#1588
Closed
emiddleton wants to merge 1 commit intorust-ndarray:masterfrom
Closed
Add optional half crate support for ScalarOperand#1588emiddleton wants to merge 1 commit intorust-ndarray:masterfrom
emiddleton wants to merge 1 commit intorust-ndarray:masterfrom
Conversation
Add `half` feature flag with optional dependency on the `half` crate. When enabled, implements `ScalarOperand` for `half::f16` and `half::bf16`, allowing these types to participate in array arithmetic operations. This enables the burn-ndarray backend to support bf16/f16 tensor operations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Thanks for your contribution, Edward. However, this PR does the same, and more, so we're gonna continue with that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
halffeature flag with optional dependency on thehalfcrate. When enabled, implementsScalarOperandforhalf::f16andhalf::bf16, allowing these types to participate in array arithmetic operations.This enables the burn-ndarray backend to support bf16/f16 tensor operations.