Skip to content

elf: remove From impl #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phip1611 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

elf: remove From impl #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions multiboot2/src/elf_sections.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ impl ElfSectionsTag {
/// Returns the string table data, if it's present.
#[must_use]
pub fn string_table(&self) -> Option<&[u8]> {
let shdr_table: SectionHeaderTable<NativeEndian> = self.into();
let shdr_table = SectionHeaderTable::new(NativeEndian, self.class(), &self.sections);

@phip1611 phip1611 Jun 15, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @an-owl - I think the From impl was not very idiomatic Rust. I decided to switch back to a normal constructor.

Nevertheless: thanks for your contribution!


// Info for this here
// https://docs.oracle.com/cd/E23824_01/html/819-0690/chapter6-43405.html @ `e_shstrndx`
Expand Down Expand Up @@ -106,12 +106,6 @@ impl ElfSectionsTag {
}
}

impl<'a> From<&'a ElfSectionsTag> for SectionHeaderTable<'a, NativeEndian> {
fn from(value: &'a ElfSectionsTag) -> Self {
SectionHeaderTable::new(NativeEndian, value.class(), &value.sections)
}
}

impl MaybeDynSized for ElfSectionsTag {
type Header = TagHeader;

Expand Down