rework dns_names helper, remove alloc req.#178
Merged
cpu merged 22 commits intorustls:mainfrom Sep 20, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch reworks the
EndEntityCert'sdns_nameshelper. Principally it:dns_namesand the correspondingsubject_name::list_cert_dns_namesfns to be infallible, this better matches how we're ignoring invalid DNS names when validating a subject name since ignore invalid value validating dns name list #69.allocrequirement for thedns_namesfn.as_strinstead of aFromimplGeneralDnsNameReftype (with the potential to restore as future work c.f. RestoreGeneralDnsNameRef, use inGeneralName::DnsName. #183)subject_name::list_cert_dns_namesfree-standing fn to be associated withCertand namedvalid_dns_names.Resolves #46, replaces #50