fix(ci): SAST actually scans the code + drop deprecated flaky semgrep action#930
Merged
Merged
Conversation
… action Two real problems in the Static Application Security Testing job: 1. **It scanned a path that no longer exists.** `bandit -r src/` and `semgrep … src/` pointed at the repo-root `src/`, but the Python code moved to `archive/v1/src/` (64 .py files) when the runtime was rewritten in Rust. So the SAST scan matched nothing — a silent no-op (this is also why `bandit-results.sarif` was "Path does not exist" on recent runs). Fixed both to `archive/v1/src/`. 2. **Deprecated + redundant + flaky semgrep step.** The `returntocorp/semgrep-action@v1` step pulled `returntocorp/semgrep-agent:v1` from Docker Hub every run (intermittently timing out → red check, e.g. on #929) and is EOL. It was redundant: the pip `semgrep --sarif` step is what feeds GitHub Security; the action only pushed to the Semgrep cloud app via SEMGREP_APP_TOKEN. Removed it and folded its `p/docker` + `p/kubernetes` rulesets into the pip semgrep command, so coverage is preserved with no Docker pull. The job stays `continue-on-error: true` (non-gating). YAML validated. Co-Authored-By: claude-flow <ruv@ruv.net>
This was referenced Jun 3, 2026
ruvnet
added a commit
that referenced
this pull request
Jun 3, 2026
Per the CLAUDE.md pre-merge checklist (item 5, "Add entry under [Unreleased]"), several recently-merged PRs landed without CHANGELOG entries. Backfilling the user/operator-facing ones — most importantly the MAT triage safety fix: - #926 (Security/safety): survivor with a heartbeat never triaged Deceased - #918: per-node HA devices report each node's own presence/motion - #919: actionable --model load diagnostic (refs #894) - #920: --export-rvf no longer silently produces a placeholder model - #929 (Security): bearer scheme matched case-insensitively (RFC 6750) CI-internal fixes (#925 rust-cache, #930 SAST) are intentionally omitted — they don't change product behavior. Docs-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two real problems in the SAST job (
security-scan.yml)1. It scanned a non-existent path — silent no-op.
bandit -r src/andsemgrep … src/target the repo-rootsrc/, but the Python code moved toarchive/v1/src/(64.pyfiles) when the runtime was rewritten in Rust. So the security scan matched nothing. (It's also why recent runs loggedPath does not exist: bandit-results.sarif.) Fixed both toarchive/v1/src/.2. Deprecated + redundant + flaky semgrep step.
The
returntocorp/semgrep-action@v1step pulledreturntocorp/semgrep-agent:v1from Docker Hub on every run — which intermittently timed out and turned the check red (e.g. on #929) — and the action is EOL. It was also redundant: the pipsemgrep --sarifstep is what actually feeds GitHub Security; the action only pushed to the Semgrep cloud app (SEMGREP_APP_TOKEN). Removed it and folded itsp/docker+p/kubernetesrulesets into the pipsemgrepcommand, so ruleset coverage is preserved with no Docker pull.Net effect
Job stays
continue-on-error: true(non-gating). YAML validated; corrected path confirmed to contain 64.pyfiles.🤖 Generated with claude-flow