ci: allow dependency manifest policy bumps#134
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 407c389b42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const isRustTest = (file) => /^src-tauri\/tests\//.test(file); | ||
| const isPythonTest = (file) => /^search-api\/tests\//.test(file) || /^search-api\/test_.*\.py$/.test(file); | ||
|
|
||
| const dependencyManifestFiles = new Set([ |
There was a problem hiding this comment.
The hard-coded manifest allowlist is incomplete for this repo: git ls-files shows tracked manifests such as src-tauri/fuzz/Cargo.toml and docs/deck/package.json that are not in this set. When a dependency-only bump touches search-api/requirements.txt plus one of those manifests, prodChanged is true but dependencyManifestOnly becomes false, so the new exemption still rejects the PR as “production code changed without test updates” even though every changed file is a dependency manifest.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
Note: local lint-staged/eslint could not run because this workstation's node_modules install is missing published package build files; GitHub CI will run from a fresh install.