chore: update to phpstan major version 2#255
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
=========================================
Coverage 94.21% 94.21%
+ Complexity 264 263 -1
=========================================
Files 15 15
Lines 881 881
=========================================
Hits 830 830
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phil-davis
commented
Jan 6, 2025
Comment on lines
88
to
+86
| $contentLength = $this->getHeader('Content-Length'); | ||
| if (null !== $contentLength && (is_int($contentLength) || ctype_digit($contentLength))) { | ||
| if (null !== $contentLength && ctype_digit($contentLength)) { |
Contributor
Author
There was a problem hiding this comment.
getHeader can only return string or null. So is_int() is useless code.
phil-davis
commented
Jan 6, 2025
Comment on lines
202
to
+203
| $test = preg_match('/^AWS$/', $this->response->getHeader('WWW-Authenticate'), $matches); | ||
| self::assertTrue(true == $test, 'The WWW-Authenticate response didn\'t match our pattern'); | ||
| self::assertTrue(1 === $test, 'The WWW-Authenticate response didn\'t match our pattern'); |
Contributor
Author
There was a problem hiding this comment.
preg_match returns (int) 1 not (bool) true.
phil-davis
commented
Jan 6, 2025
| $this->response->getHeader('WWW-Authenticate'), $matches); | ||
|
|
||
| self::assertTrue(true == $test, 'The WWW-Authenticate response didn\'t match our pattern. We received: '.$this->response->getHeader('WWW-Authenticate')); | ||
| self::assertTrue(1 === $test, 'The WWW-Authenticate response didn\'t match our pattern. We received: '.$this->response->getHeader('WWW-Authenticate')); |
Contributor
Author
There was a problem hiding this comment.
preg_match returns (int) 1 not (bool) true.
phil-davis
commented
Jan 6, 2025
|
|
||
| /** | ||
| * @backupGlobals | ||
| * @backupGlobals enabled |
Contributor
Author
There was a problem hiding this comment.
backupGlobals should explicitly have the keyword "enabled"
Member
There was a problem hiding this comment.
Did this annotation work as expected in phpunit without the suffix? If not we might just drop it
staabm
approved these changes
Jan 6, 2025
staabm
reviewed
Jan 6, 2025
phil-davis
force-pushed
the
phpstan-2.1
branch
2 times, most recently
from
1778353 to
e9e5ed0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #254
After this is reviewed and merged, I will look at doing similar in the 6.0 branch also.