Fix telescope response middleware when response body only contains integer but content-type header of response says its json#76
Merged
Sammyjo20 merged 2 commits intosaloonphp:v3from Feb 26, 2026
Conversation
gdebrauwer
changed the title
gdebrauwer
changed the title
Collaborator
|
This fix is good! |
Sammyjo20
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm dealing with annoying third-party api call that sends a response with the
content-type: application/jsonheader but the response body is just an integer (= an id). Currently theTelescopeResponseMiddlewarethrows an exception because the decoded 'json' is an integer instead of an array or string. This PR ensures that the middleware does not fail anymore in that case.