fix get_interface_info_wmi returning the default gateway as "broadcast" (#68692)#68693
Closed
hurzhurz wants to merge 1 commit intosaltstack:3006.xfrom
Closed
fix get_interface_info_wmi returning the default gateway as "broadcast" (#68692)#68693hurzhurz wants to merge 1 commit intosaltstack:3006.xfrom
hurzhurz wants to merge 1 commit intosaltstack:3006.xfrom
Conversation
Contributor
|
This appears to be fixing the same issue as #68696, but that PR is actually adding the broadcast value too and has some tests added. |
Contributor
|
This will also need a test |
Contributor
Author
Shure, please go ahead :) I didn't bother writing a test because it didn't bug anyone that there was none related before and I didn't even change any logic. Well and to be honest, after someone else created a whole bunch of PRs (maybe with AI?), also another PR based on my finding, I'm not motivated to do any more work on this... |
Contributor
|
Closing in favor of #68696 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Trivial and obvious change/fix for salt.utils.win_network.get_interface_info_wmi().
What issues does this PR fix or reference?
Fixes #68692