add mTLS for the salt api#69441
Open
bochi wants to merge 2 commits into
Open
Conversation
- Rename changelog/api-mtls.added.md to changelog/69441.added.md to match the PR number naming convention enforced by the Check Changelog Entries hook. - Strip trailing whitespace from the ssl_allowed_cn docstring in salt/netapi/rest_cherrypy/app.py. - Add blank line after module docstring in tests/pytests/unit/netapi/cherrypy/test_ssl_cn_filter.py per black formatting. Co-authored-by: Stefan Bogner <bochi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds optional mutual TLS (client certificate validation) to the
rest_cherrypyAPIThree new
rest_cherrypyoptions:ssl_ca_certs— file or directory with the trust-anchor PEM certificatesssl_cert_reqs— peer verification policy, one ofCERT_NONE(default),CERT_OPTIONALorCERT_REQUIRED.ssl_allowed_cn— optional list of allowed Subject CN values.What issues does this PR fix or reference?
Fixes
No fixes, its a feature
New Behavior
Support for mTLS Auth either in addition to existing auth or seperate.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No