Conversation
…gress updates - Implement `hasSignificantMediaChange()` to perform deep metadata comparisons (playback state, title, artist, album art, buffering state, like status, and track duration). - Ignore minor progress elapsed time ticks during comparison to eliminate the CPU-intensive, every-second WebSocket synchronization loop. - Significantly reduce battery consumption, CPU overhead, and WebSocket network payloads on the Android client.
…VICE and optimize service start logic
perf(android): optimize seekbar sync and filter out trivial media progress updates
…r regardless of discovery mode
…prevent memory leaks
…ent, and IP address state handling
github-project-automation
Bot
moved this from Backlog
to Done
in AirSync Features and Bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to device connection management, discovery, and UI clarity in the AirSync app. The main changes enhance how device details are handled during connections, improve the reliability of device discovery, and add visual cues for device discovery sources. Additionally, the foreground service handling is updated for better compatibility with newer Android versions.
Device Connection and State Management:
connectfunction inAirSyncMainScreen.ktnow explicitly acceptsipAddress,port, andsymmetricKeyparameters, allowing more precise control over connection attempts and ensuring the correct credentials are used when connecting to devices. [1] [2] [3] [4]AirSyncViewModelinitialization and connection status listener logic are enhanced to more accurately reflect the current connection state, update the last connected device, and persist the active IP address. [1] [2]Device Discovery Improvements:
DiscoveryOrchestratorinstead of the legacyUDPDiscoveryManager, enabling support for multiple discovery protocols and more robust device detection. [1] [2]Foreground Service and Notification Updates:
QuickShareServiceis updated to useServiceInfo.FOREGROUND_SERVICE_TYPE_CONNECTED_DEVICEon Android Q and above, ensuring compliance with newer Android requirements and preventing background execution issues. [1] [2] [3] [4]Context Management and Miscellaneous:
These changes collectively improve connection reliability, discovery robustness, and user experience in the AirSync application.