Skip to content

[dev] Pull accessioning out of samples#5615

Merged
StephenHulme merged 8 commits intodevelopfrom
sh51/accessioning-changes
Mar 18, 2026
Merged

[dev] Pull accessioning out of samples#5615
StephenHulme merged 8 commits intodevelopfrom
sh51/accessioning-changes

Conversation

@StephenHulme
Copy link
Copy Markdown
Contributor

@StephenHulme StephenHulme commented Mar 17, 2026

The Sample model class is unweidly and accessioning logic is now better separated.

Changes proposed in this pull request

  • Extract accessioning logic out of sample model into a concern
  • Remove unused REXML imports
  • Update rubocop todo

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme added the Accessioning Epic in technical roadmap June 2025, relating to improving the accessioning code. label Mar 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 86.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.18%. Comparing base (42f303e) to head (2f0308f).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
app/models/sample_accessioning.rb 85.71% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5615      +/-   ##
===========================================
- Coverage    87.23%   87.18%   -0.05%     
===========================================
  Files         1460     1461       +1     
  Lines        33001    33003       +2     
  Branches      3470     3470              
===========================================
- Hits         28787    28773      -14     
- Misses        4193     4209      +16     
  Partials        21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful refactoring

@StephenHulme StephenHulme merged commit 430e83a into develop Mar 18, 2026
28 checks passed
@StephenHulme StephenHulme deleted the sh51/accessioning-changes branch March 18, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessioning Epic in technical roadmap June 2025, relating to improving the accessioning code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants