fix: Add timeout configuration for MCP servers #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 5-minute Istio VirtualService timeout for MCP servers - Add 10-minute aiohttp ClientSession timeout for MCP passthrough forwarders - Fixes 30-second timeout errors causing MCP request failures MCP servers often have long-running operations that exceed the default 30-second Istio timeout. This change: 1. Detects MCP servers by checking if forwarder_type is 'passthrough' and routes contain '/mcp' 2. Sets Istio VirtualService timeout to 5 minutes for MCP servers 3. Sets aiohttp ClientSession timeout to 10 minutes for MCP passthrough forwarders 4. Keeps default timeouts for non-MCP endpoints
ashwin-ranade
force-pushed
the
asr/fix-mcp-timeout
branch
from
bbb5a58 to
841b6c1
Compare
ashwin-ranade
changed the title
Revert orphaned resource cleanup logic that was added for handling cases where DB records don't exist but K8s resources do. This simplifies the delete endpoint logic to just raise ObjectNotFoundException when the endpoint doesn't exist in the DB.
…le empty MCP_TIMEOUT
… of removing all whitespace lines
…without trailing newline
…unctionality only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds timeout configuration for MCP servers to prevent hanging requests and fix 30-second timeout errors.
Problem
MCP servers often have long-running operations that exceed the default 30-second Istio timeout, causing request failures.
Solution