change hook weight to -1 (job has to run after config maps placed)#776
Open
change hook weight to -1 (job has to run after config maps placed)#776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change hook weight for the job to -1 (the config maps with hook weight -2 need to be created in order for the job to succeed)
Greptile Summary
This PR adjusts the Helm pre-install/pre-upgrade hook weight for
database_init_job.yamlfrom-2to-1, ensuring the database initialization job runs after config maps (which carry hook weight-2) are fully created. The change addresses a real ordering issue where the init job previously ran in parallel with config map creation.The weight adjustment is sound and solves the immediate problem stated in the PR: ensuring config maps are ready before the job starts.
Confidence Score: 4/5
-1ensures the init job runs after all weight-2hooks (config maps) complete, which is the stated goal. No concrete issues are introduced by this change.Last reviewed commit: c6a75ba