Skip to content

change hook weight to -1 (job has to run after config maps placed)#776

Open
masbarnes wants to merge 1 commit intomainfrom
hook-weight-bug-fix
Open

change hook weight to -1 (job has to run after config maps placed)#776
masbarnes wants to merge 1 commit intomainfrom
hook-weight-bug-fix

Conversation

@masbarnes
Copy link
Collaborator

@masbarnes masbarnes commented Mar 10, 2026

Change hook weight for the job to -1 (the config maps with hook weight -2 need to be created in order for the job to succeed)

Greptile Summary

This PR adjusts the Helm pre-install/pre-upgrade hook weight for database_init_job.yaml from -2 to -1, ensuring the database initialization job runs after config maps (which carry hook weight -2) are fully created. The change addresses a real ordering issue where the init job previously ran in parallel with config map creation.

The weight adjustment is sound and solves the immediate problem stated in the PR: ensuring config maps are ready before the job starts.

Confidence Score: 4/5

  • The change safely resolves the config map ordering issue without introducing verified problems.
  • The PR makes a focused, intentional change to fix a specific ordering bug. The new weight -1 ensures the init job runs after all weight -2 hooks (config maps) complete, which is the stated goal. No concrete issues are introduced by this change.
  • No files require special attention

Last reviewed commit: c6a75ba

@masbarnes masbarnes requested a review from arniechops March 10, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant