-
Notifications
You must be signed in to change notification settings - Fork 254
CLDSRV-827: Fix contentLength and objectSize in access logs #6051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix contentLength to capture actual transfer size (egress for GET, ingress for PUT) instead of always using request body size. This restores backwards compatibility with S3 analytics. Fix objectSize to always reflect full object size by passing metadata from objectGet, preventing partial sizes in range get.
Hello dvasilas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
|
/approve |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: git fetch
git checkout -B w/9.3/bugfix/CLDSRV-827 origin/development/9.3
git merge origin/bugfix/CLDSRV-827
# <intense conflict resolution>
git commit
git push -u origin w/9.3/bugfix/CLDSRV-827The following options are set: approve |
|
🤖 |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
Queue build failedThe corresponding build for the queue failed:
Remove the pull request from the queue
|
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-827. Goodbye dvasilas. |
The
contentLengthfield in S3 analytics captures egress (response size) forGetObjectoperations and ingress (request size) forPutObject.In server access logs,
contentLengthwas the HTTP request body size (bytes received from client).This broke backwards compatibility with S3 analytics, and caused an Integration test to fail.
The fix is to update
contentLengthto capture transfer size (egress for GET, ingress for PUT).This PR includes a second fix for
objectSizeto always reflect full object size (and not sizes in range get operations).Intregration bulid with this fix: https://github.com/scality/Integration/actions/runs/21141099093