-
Notifications
You must be signed in to change notification settings - Fork 254
CLDSRV-829: Increase KMS load test tolerance from 10% to 20% #6054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDSRV-829: Increase KMS load test tolerance from 10% to 20% #6054
Conversation
The test was flaky due to stricter tolerance on load distribution across KMIP nodes. Enhanced error message to include deviation details for better debugging. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Hello bourgoismickael,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
|
ping |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
|
/create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: git fetch
git checkout -B w/9.3/improvement/CLDSRV-829-flaky-kms-load-repartition origin/development/9.3
git merge origin/w/9.2/improvement/CLDSRV-829-flaky-kms-load-repartition
# <intense conflict resolution>
git commit
git push -u origin w/9.3/improvement/CLDSRV-829-flaky-kms-load-repartitionThe following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses test flakiness in the KMS load test by relaxing the tolerance for load distribution across KMIP nodes from 10% to 20%. The change acknowledges that the round-robin distribution of requests is confined to individual Node.js cluster processes, which can lead to natural variance in packet distribution that exceeds the previous 10% threshold.
Changes:
- Increased the load distribution tolerance from 10% to 20% to reduce test flakiness
- Enhanced the error message to include deviation details (±APPROX, min, max values) for better debugging
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve, create_integration_branches |
Queue build failedThe corresponding build for the queue failed:
Remove the pull request from the queue
|
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-829. Goodbye bourgoismickael. |
The test was flaky due to stricter tolerance on load distribution across KMIP nodes.
Enhanced error message to include deviation details for better debugging.