Allow the panel sheet to go above the upper position when it is in full state#569
Open
engali94 wants to merge 772 commits intoscenee:masterfrom
Open
Allow the panel sheet to go above the upper position when it is in full state#569engali94 wants to merge 772 commits intoscenee:masterfrom
engali94 wants to merge 772 commits intoscenee:masterfrom
Conversation
Release 1.7.1
* Added nearbyPosition : always a position of a user's finger. * debugging nearby position in Maps.app. * Added test cases move with nearby position.
This seems to be Xcode 11's bug of linking frameworks.
This issue is that a panel moved up while dragging it down if content offset of the tracking scroll view in a content view controller was greater than its top interaction buffer. Ref. scenee#293
The grabber area was not working expectedly.
Fix a panel's move-up while dragging it down
Ideally, it's better to define a delegate method like scrollViewDidEndDragging(_:willDecelerate:) in FloatingPanelControllerDelegate to notify whether a panel will be decelerated or not. However it's a broken change so I add this change as workaround. The delegate method definition will be improved on v2.0.
Fix delegate calls
Return the child view controller to consult
Release 1.7.2
Minor README.md typo
…#314) * add floatingPanel(_:contentOffsetForPinning:) * add 'Show NavigationController' sample * fix the initial content offset in a navigation bar with a large text The content offset preservation should be applied only when `FloatingPanelController.contentInsetAdjustmentBehavior` is `.always`. This is because the library user loses control of the initial offset.
* add multi panel sample
* Convert the tracked scroll view frame to the surface coordinate space
Release 1.7.3
fixes floatingPanel(_ vc: FloatingPanelController, contentOffsetForPinning) name
Release 1.7.4
…sition (scenee#527) Changed how `initialScrollOffset` is set. This issue was described in scenee#526.
Release 2.5.2
Co-authored-by: 黄宝成 <huangbc@publink.cn>
* Updated 'ci' workflow for Xcode 13.3.1 * Modernized and simplified the workflow using 'strategy.matrix' * 'arm64-apple-ios15.4' target is not included in swiftpm because its build gets an build error.
With Xcode 14 Beta 1 library fails to compile with following error. > Stored properties cannot be marked potentially unavailable with `@available` Because CALayerCornerCurve is not marked with any @available annotation it is possible to declare private optional storage of it.
Resolved Maps-SwiftUI Example Animation Stuttering (scenee#546)
Release 2.5.3
Fix the view index of FloatingPanelView for SwiftUI
This resolves issue scenee#561. Instead of continuing to work a modal presentation transition even if a panel state is not .hidden, this library calls fatalError as a programmer error on the occasion.
This job is unstable because of its environment.
Release 2.5.4
'Show Top Positioned Panel' in Samples app was broken.
Owner
We are able to allow this behavior without introducing a new API. See this code in Maps sample FloatingPanel/Examples/Maps/Maps/MainViewController.swift Lines 178 to 184 in f917316 It limits the most upper position of the panel to 6pt above the .full position. We can also customize the limitation and handle other positioned panel(top, left and right) along with user specific use cases. See also here: https://github.com/scenee/FloatingPanel#specify-the-panel-moves-boundary |
engali94
force-pushed
the
bounds-overshoot
branch
from
4fcec62 to
29bf974
Compare
scenee
force-pushed
the
master
branch
2 times, most recently
from
fdf8181 to
d517720
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the panel sheet to go above the upper position when it is in the
.fullstate