Conversation
…e callbacks (#680) When using `floatingPanelState(_:)` together with `FloatingPanelControllerDelegate` methods that trigger SwiftUI view updates (e.g. opacity changes), the delegate callbacks caused a SwiftUI re-render which in turn called `update(state:)` with the current state. This redundant `controller.move(to:state, animated: false)` call during a drag gesture interrupted the panel's interactive transition. Skip the `move(to:animated:)` call when the controller is already in the requested state.
scenee
force-pushed
the
iss-680
branch
2 times, most recently
from
c10ce2f to
99a3985
Compare
Add lastKnownBindingState tracking to CoordinatorProxy.update(state:) to skip moves when the binding value hasn't actually changed, preventing delegate callbacks from reverting the panel to a stale state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
floatingPanelState(_:)breaking panel interactivity when used withFloatingPanelControllerDelegatemethods that trigger SwiftUI re-renders (e.g. opacity changes). Delegate callbacks caused redundantmove(to:animated:)calls during drag gestures, interrupting the interactive transition.Added
lastKnownBindingStatetracking inCoordinatorProxy.update(state:)to skip moves when the binding value hasn't actually changed, preventing stale state from reverting the panel position.CoordinatorProxyTestsand reorganize existing tests into aUIKitsubfolder.Improvement
Closes #680