Pinned actions versions and add Dependabot configuration#62
Pinned actions versions and add Dependabot configuration#62bsipocz merged 6 commits intoscientific-python:mainfrom
Conversation
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
bsipocz
left a comment
There was a problem hiding this comment.
Thank you!
Some minor comments for the config, otherwise it looks good.
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
|
Thanks! |
| python -m pip install pytest more-itertools | ||
| - name: produce the issue body | ||
| shell: bash -l {0} | ||
| run: | | ||
| python $GITHUB_ACTION_PATH/parse_logs.py ${{ inputs.log-path }} |
There was a problem hiding this comment.
I'd probably use uv run for this (in a new PR). Am I correct in assuming that what you're looking for is a lock file?
There was a problem hiding this comment.
Yes, precisely. I'm not using uv yet, but that's what I had in mind using something like:
python -m pip install --require-hashes -r CI/requirements.txt
There was a problem hiding this comment.
the only reason I used pip when writing this action is because that was the one I was most familiar with at the time. Considering that using uv would allow us to use a fully isolated env for this action and thus avoid clashing with the activated environment, I believe that would actually be a welcome side-effect.
|
Darn, it looks like the following is invalid: Better to simply drop that entry. |
Closes #61
Changes
pre-commithooksDiscussion
The action relies on
pytestandmore-itertools. These could also be pinned according to their hashes if we were to usepip-tools(and also updated automatically by Dependabot). I can quickly add this on if people would like.