Skip to content

addConsCumulative#1223

Open
tias wants to merge 1 commit into
scipopt:masterfrom
tias:cumulative
Open

addConsCumulative#1223
tias wants to merge 1 commit into
scipopt:masterfrom
tias:cumulative

Conversation

@tias
Copy link
Copy Markdown

@tias tias commented May 27, 2026

Hi Joao,

Thanks for the very clear instructurions. With the help of a well-supervised digital friend I created a test-passing PR.

Does that look OK?

Note that I see tons of changes to 'src/pyscipopt/scip.pyi' but I think that is an artefact of code generation, I did not edit this file.

Even if good, don't merge it yet. We will first connect it to CPMpy so we can run our larger test-suite to make sure everything behaves appropriately.

Forgot to write that this is a follow-up to #1222

@Joao-Dionisio Joao-Dionisio self-requested a review May 28, 2026 08:36
@Joao-Dionisio
Copy link
Copy Markdown
Member

Joao-Dionisio commented May 28, 2026

Thank you for the quick follow-up @tias !

On the .pyi file, I think the issue is with our common digital friend :) This year we started adding stubs so that code editors could auto-complete (see #1072), meaning that every function addiction must also come with a 1 or 2 line addition to the pyi file describing the input/output (forgot this step, sorry 😬 ). This is tedious, so I decided to create an automatic stub generator, that unfortunately is still a WIP, as you can see. The way forward is just telling the digital friend to roll back these pyi changes, and just add directly the consCumulative() ones, not using the stub generating script.

EDIT: But other than this it does look okay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants