OpenGL: Consolidate depth–stencil buffers (Strategy 2)#7360
Merged
wookieejedi merged 4 commits intoscp-fs2open:masterfrom Apr 15, 2026
Merged
OpenGL: Consolidate depth–stencil buffers (Strategy 2)#7360wookieejedi merged 4 commits intoscp-fs2open:masterfrom
wookieejedi merged 4 commits intoscp-fs2open:masterfrom
Conversation
wookieejedi
added
cleanup
BMagnu
approved these changes
Apr 10, 2026
Member
BMagnu
left a comment
BMagnu
left a comment
There was a problem hiding this comment.
Yeah, this looks reasonably good.
Ran tests in cases that are known to read from stencils, as well as depth (such as volumetric nebulae). Seems all fine, and the renderdoc looks good too.
This works to remove the two unnecessary textures as the first step to closing the issue. Further thought on when to use depth vs position.z can and should be done in a different PR as to not muddle this cleanup.
Contributor
Author
|
Ah! Good to know. So going further would mean having to do it in a different PR you say? So this remains as is am guessing? |
Member
|
Yup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tackles #7325 and partially implements Strategy 2, the build succeeds and in‑game behavior appears normal. The main goal of this PR is to get feedback on whether this approach is on the right track for Strategy 2 before extending the changes to other depth/stencil buffers. This is not complete however.