Negate during warpout shockwaves jostling ships#7372
Open
LuytenFS wants to merge 2 commits intoscp-fs2open:masterfrom
Open
Negate during warpout shockwaves jostling ships#7372LuytenFS wants to merge 2 commits intoscp-fs2open:masterfrom
LuytenFS wants to merge 2 commits intoscp-fs2open:masterfrom
Conversation
wookieejedi
added
cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to fix: #6444, however the only other question would be, is if we also apply this fix to when ships are within just the early stages of the warpout sequence when they're still vulnerable. Because during my tests the ships, including the player's are still jostled by the shockwaves in the early stages, only when the camera takes over as seen in the player's video does the fix take into place, so this is really a very short window in which ships don't get jostled, which would defeat what the fix is trying to do.
FIXED.mp4
LATEST-NIGHTLY-UNFIXED.mp4
FIXED-WITH-PLAYER.mp4