Conversation
…n Source Language Screen
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
note @catreedle: The above commits have added the final working versions of the contracts. Could you integrate them and delete the JSON versions of the contracts in this PR? Please let us know if you're having issues with them! |
sure @andrewtavis. Thank you! |
|
I have integrated to using YAML contracts and deleted the JSON contract @andrewtavis. It is working as expected aside from this issue. |
|
Amazing, @catreedle! Thanks for the quick work here :) |
|
@angrezichatterbox, @DeleMike: Would you two have a moment to look this over? |
|
@andrewtavis What was the all languages download button supposed to do ? |
|
It was supposed to make a request for all the languages that the user has installed - so trigger all of the individual downloads. |
That doesn't work right now when I tried. |
I have not implemented that functionality. I will notify here when I have. :) |
|
Contracts are updated here now, @catreedle! Please let us know if you have any questions about them! Once the functionality is updated to use all data based on the order of the indexes we'll be able to bring this in! 😊 |
|
Note @angrezichatterbox and @DeleMike: In the sync we realized we needed one (hopefully) final update of the contracts. We now have all conjugations and declensions being fully indexed, which allows us to explicitly place them in specific fields of the tables. We don't need to sort any response from the contracts. be39d68 has the changes 😊 |
|
And just checking, @catreedle: Plan for this is that we first merge in this PR, and then we can work on bringing in #550? |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR adds call to Scribe-Server API and write the response into SQLite database for the download language functionality.
New Files:
Changes:
Related issue