[v1.3] 接受 @version 没有或空值 #1216
Merged
[v1.3] 接受 @version 没有或空值 #1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 让脚本元数据中的 @version 字段在缺失或为空时也能被接受，从而提升对 Tampermonkey/Violentmonkey 导出脚本的兼容性；同时在多个页面/服务逻辑中对版本展示与比较增加了默认回退值。
Changes:
- 安装/解析流程不再强制要求
@version非空（允许缺失/空值）。 - UI 中多个列表视图对缺失版本统一回退显示为
"0.0"，安装页部分场景显示"N/A"。 - 更新检查、忽略版本逻辑与 GM_info 输出对缺失版本做了默认值处理，避免因版本缺失导致流程中断。
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pkg/utils/script.ts | 放开 @version 非空校验，允许缺失/空值版本进入安装/更新流程 |
| src/pages/options/routes/SubscribeList.tsx | 订阅列表版本列缺失时回退显示 "0.0" |
| src/pages/options/routes/ScriptList/ScriptTable.tsx | 脚本表格视图版本列缺失时回退显示 "0.0" |
| src/pages/options/routes/ScriptList/ScriptCard.tsx | 卡片视图版本渲染条件调整（当前会在缺失/空版本时不显示） |
| src/pages/install/App.tsx | 安装页旧版本/当前版本展示逻辑调整，对缺失版本回退 "N/A" 并增强类型判断 |
| src/pages/batchupdate/App.tsx | 批量更新页忽略版本判断增加类型保护，避免非字符串参与比较/传参 |
| src/app/types.d.ts | IsInstalledResponse 中 installed=true 时的 version 改为必填 string |
| src/app/service/service_worker/subscribe.ts | 订阅更新检查对缺失版本回退 "0.0" 并继续比较 |
| src/app/service/service_worker/script_update_check.ts | 更新检查目标站点过滤逻辑对版本取值增加类型保护 |
| src/app/service/service_worker/script.ts | 脚本更新检查/日志版本字段回退 "0.0"；isInstalled 返回缺失版本回退；新增了调试 console 输出 |
| src/app/service/content/gm_api/gm_info.ts | GM_info 的 script.version 在缺失时回退 "0.0" |
Comments suppressed due to low confidence (2)
src/app/service/service_worker/script.ts:1194
isInstalled里新增的 console.log/console.error（还包含 script 对象）会把用户脚本信息输出到控制台，容易造成噪音与潜在信息泄露，也不适合发布版本。建议移除这些调试输出，若需要诊断请改用现有 logger 并加可控的 debug 开关。
return script;
})
)
).sort((a, b) => a.sort - b.sort);
await this.scriptDAO.updates(batchUpdate);
src/pages/options/routes/ScriptList/ScriptCard.tsx:241
- 当前卡片视图里版本展示条件改成了
item.metadata.version?.[0]为真才渲染；当脚本没有 @Version 或 @Version 为空字符串时，这里会直接不显示版本，与表格视图/订阅列表里统一回退显示 "0.0" 的行为不一致，也与 PR 描述“显示 0.0”不完全匹配。建议这里也做同样的回退展示，或至少保持各视图一致。
<div className="tw-flex tw-flex-row tw-gap-4 tw-text-sm tw-text-gray-500">
{item.metadata.version?.[0] && (
<div>
<span className="tw-font-medium">
{t("version")}
{": "}
</span>
<span>{item.metadata.version[0]}</span>
</div>
Comment on lines
+203
to
+205
| const scriptVersion = metadata.version?.[0]; | ||
| const oldScriptVersion = typeof scriptVersion === "string" ? scriptVersion : "N/A"; | ||
| setOldScriptVersion(oldScriptVersion); |
There was a problem hiding this comment.
安装页这里把缺失/空的版本显示为 "N/A"，而其它列表页回退显示为 "0.0"。如果目标是“跟 TM 一样显示 0.0”，建议这里也统一回退为 "0.0"；如果确实需要区分未知(N/A)与空值，请在 UI/文案上明确规则并保持各页面一致。
Comment on lines
82
to
91
| // 不接受空白name | ||
| if (!metadata.name?.[0]) { | ||
| throw new Error(i18n_t("error_script_name_required")); | ||
| } | ||
| // 不接受空白version | ||
| if (!metadata.version?.[0]) { | ||
| throw new Error(i18n_t("error_script_version_required")); | ||
| } | ||
| // 可接受空白namespace | ||
| if (metadata.namespace === undefined) { | ||
| throw new Error(i18n_t("error_script_namespace_required")); | ||
| } | ||
| // 可接受空白version | ||
| let type = SCRIPT_TYPE_NORMAL; |
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CodFrm
reviewed
Feb 12, 2026
Member
There was a problem hiding this comment.
应该为 prepareScriptByCode 添加单元测试才对，parseMetadata有覆盖过了，这添加的这几个没什么用，我处理一下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
跟 TM 一样。会显示 "0.0"，但内部处理不设为 "0.0"
只在显示改变
(部份情况会显示 "N/A" ）
安装或更新时可接受不输入 "0.0"
这样 VM的导出 和 其他TM脚本 都能正常安装了