perf: account deserialization cache, access list pooling#2846
Draft
pdrobnjak wants to merge 4 commits intoperf/event-marking-vis-reuse-eventmgr-poolfrom
Draft
perf: account deserialization cache, access list pooling#2846pdrobnjak wants to merge 4 commits intoperf/event-marking-vis-reuse-eventmgr-poolfrom
pdrobnjak wants to merge 4 commits intoperf/event-marking-vis-reuse-eventmgr-poolfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
pdrobnjak
force-pushed
the
perf/account-deser-cache-accesslist-pool
branch
from
06e97ec to
e06b8ed
Compare
1. Remove redundant sort.Strings in SetWriteset/SetEstimatedWriteset
2. Replace 3 global RWMutex+maps with per-tx-index txSlot array
3. Replace select{} workers with for-range + defer close
4. Pool giga EVM executors via sync.Pool within a block
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Pool VersionIndexedStore via sync.Pool to avoid per-tx per-store map allocations (~10 GB reduction) - Add CacheMultiStoreForOCC to build child CMS directly with VIS stores, bypassing intermediate storeParents copy (~16 GB reduction) - Change ReadSet from map[string][][]byte to map[string]ReadSetEntry to eliminate per-key slice allocations (~4.5 GB reduction) - Reuse versionStoresBuf map across task incarnations (~1 GB reduction) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…hot release - MarkEventsToIndex: modify events in-place instead of copying (~4.5 GB) - NewEvent: pre-allocate attributes slice to exact size - EventManager: sync.Pool for reuse across EVM snapshots (~2-3 GB) - VIS Reset: clear() maps instead of make() via clone-on-store (~4 GB) - SetReadset/SetIterateset clone data before storing in txSlot - Reset() reuses existing map/slice capacity - RevertToSnapshot: release CMS stores and EventManagers from discarded contexts back to sync.Pools (~5-8 GB) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add per-context account cache to avoid repeated protobuf unmarshal in hot paths like LockedCoins → GetAccount. Each WithMultiStore creates a fresh cache so EVM snapshot/revert correctness is maintained. Eliminates ~4 deserializations per EVM tx for the sender address alone. Pool EVM accessList structs via sync.Pool with pre-sized maps (24 addrs) to avoid per-tx map allocation. Release on DBImpl.Cleanup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pdrobnjak
force-pushed
the
perf/account-deser-cache-accesslist-pool
branch
from
e06b8ed to
cb598f8
Compare
pdrobnjak
force-pushed
the
perf/event-marking-vis-reuse-eventmgr-pool
branch
from
30b77de to
ba228a5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+422
to
+424
| parent = gs | ||
| } else if gp, ok := cms.gigaStoreParents[key]; ok { | ||
| parent = gp |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+425
to
+429
| } else if s, ok := cms.stores[key]; ok { | ||
| parent = s.(types.KVStore) | ||
| } else if p, ok := cms.storeParents[key]; ok { | ||
| parent = p.(types.KVStore) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
11/13 — depends on perf/event-marking-vis-reuse-eventmgr-pool
🤖 Generated with Claude Code