perf: swap readset ownership instead of cloning in SetReadset#2848
Draft
pdrobnjak wants to merge 1 commit intoperf/pool-cms-maps-evm-snapshotfrom
Draft
perf: swap readset ownership instead of cloning in SetReadset#2848pdrobnjak wants to merge 1 commit intoperf/pool-cms-maps-evm-snapshotfrom
pdrobnjak wants to merge 1 commit intoperf/pool-cms-maps-evm-snapshotfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
pdrobnjak
force-pushed
the
perf/swap-readset-ownership
branch
from
ac5e352 to
b07abc5
Compare
pdrobnjak
force-pushed
the
perf/pool-cms-maps-evm-snapshot
branch
from
30417de to
7f1e084
Compare
Change SetReadset to take ownership of the caller's readset map and return the slot's old readset for reuse, eliminating the per-call clone allocation (~5.6 GB / 30s). The VIS reuses the returned old map (cleared on Reset) instead of allocating fresh maps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pdrobnjak
force-pushed
the
perf/swap-readset-ownership
branch
from
b07abc5 to
63412a0
Compare
pdrobnjak
force-pushed
the
perf/pool-cms-maps-evm-snapshot
branch
from
7f1e084 to
21bbfc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetReadsetto avoid deep copy overheadStack
13/13 — depends on perf/pool-cms-maps-evm-snapshot (top of stack)
🤖 Generated with Claude Code