Skip to content

IBC Update #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kbhat1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

IBC Update #2880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sei-tendermint/light/verifier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ func VerifyNonAdjacent(
return err
}

// check if the untrusted header is within the trust period
if HeaderExpired(untrustedHeader, trustingPeriod, now) {
return ErrOldHeaderExpired{untrustedHeader.Time.Add(trustingPeriod), now}
// check if the trusted header has expired past the trusting period
if HeaderExpired(trustedHeader, trustingPeriod, now) {
return ErrOldHeaderExpired{trustedHeader.Time.Add(trustingPeriod), now}
}

if err := verifyNewHeaderAndVals(
Expand Down Expand Up @@ -124,9 +124,9 @@ func VerifyAdjacent(
return errors.New("headers must be adjacent in height")
}

// check if the untrusted header is within the trust period
if HeaderExpired(untrustedHeader, trustingPeriod, now) {
return ErrOldHeaderExpired{untrustedHeader.Time.Add(trustingPeriod), now}
// check if the trusted header has expired past the trusting period
if HeaderExpired(trustedHeader, trustingPeriod, now) {
return ErrOldHeaderExpired{trustedHeader.Time.Add(trustingPeriod), now}
}

if err := verifyNewHeaderAndVals(
Expand Down
24 changes: 24 additions & 0 deletions sei-tendermint/light/verifier_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,18 @@ func TestVerifyAdjacentHeaders(t *testing.T) {
nil,
"old header has expired",
},
// trusted header expired but untrusted header is fresh -> error
// (regression: trusting period must be checked against the trusted header,
// not the untrusted header; an attacker can always supply a fresh untrusted header)
11: {
keys.GenSignedHeader(t, chainID, nextHeight, bTime.Add(1*time.Hour), nil, vals, vals,
hash("app_hash"), hash("cons_hash"), hash("results_hash"), 0, len(keys)),
vals,
1 * time.Hour,
bTime.Add(1*time.Hour + 30*time.Minute),
nil,
"old header has expired",
},
}

for i, tc := range testCases {
Expand Down Expand Up @@ -263,6 +275,18 @@ func TestVerifyNonAdjacentHeaders(t *testing.T) {
light.ErrNewValSetCantBeTrusted{types.ErrNotEnoughVotingPowerSigned{Got: 20, Needed: 46}},
"",
},
// trusted header expired but untrusted header is fresh -> error
// (regression: trusting period must be checked against the trusted header,
// not the untrusted header; an attacker can always supply a fresh untrusted header)
6: {
keys.GenSignedHeader(t, chainID, 3, bTime.Add(1*time.Hour), nil, vals, vals,
hash("app_hash"), hash("cons_hash"), hash("results_hash"), 0, len(keys)),
vals,
1 * time.Hour,
bTime.Add(1*time.Hour + 30*time.Minute),
nil,
"old header has expired",
},
}

for i, tc := range testCases {
Expand Down
Loading