refactor: move benchmarks to benchmark/ and deduplicate init logic#2885
Open
refactor: move benchmarks to benchmark/ and deduplicate init logic#2885
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ogic benchmark-compare.sh duplicated ~120 lines of chain init/config from benchmark.sh. This refactor adds env vars (SEI_HOME, PORT_OFFSET, SEID_BIN, BENCHMARK_PHASE, LOG_FILE) to benchmark.sh and rewrites benchmark-compare.sh as a thin orchestrator that delegates init/start via those env vars. - Move scripts/benchmark.sh -> benchmark/benchmark.sh - Move scripts/benchmark-compare.sh -> benchmark/benchmark-compare.sh - Move scripts/scenarios/ -> benchmark/scenarios/ - Add benchmark/CLAUDE.md with benchmark docs - Update path references in scenarios/README.md and app/benchmark/benchmark.go - Global CLAUDE.md references benchmark/CLAUDE.md for benchmark context Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
- Add missing env vars (MOCK_BALANCES, DISABLE_INDEXER, DURATION) - Split env var table by script (benchmark.sh vs benchmark-compare.sh) - Document GIGA_EXECUTOR/GIGA_OCC default difference between scripts - Fix TPS extraction example to use LOG_FILE instead of nonexistent path - Note pprof auto-capture is compare-only; single runs need manual capture - Add scenario file listing and usage example - Document DB_BACKEND forwarding in compare script - Note minimum 2 scenarios required for compare Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2885 +/- ##
==========================================
+ Coverage 57.16% 57.18% +0.02%
==========================================
Files 2091 2091
Lines 171179 171179
==========================================
+ Hits 97853 97891 +38
+ Misses 64616 64578 -38
Partials 8710 8710
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/to top-levelbenchmark/directorySEI_HOME,PORT_OFFSET,SEID_BIN,BENCHMARK_PHASE,LOG_FILE) tobenchmark.shfor phase gating and multi-instance supportbenchmark-compare.shas a thin orchestrator that delegates init/start tobenchmark.shinstead of duplicating ~120 lines of chain init logicbenchmark/CLAUDE.mdwith benchmark documentation; globalCLAUDE.mdreferences itTest plan
benchmark/benchmark.shwith no new env vars behaves identically to the originalscripts/benchmark.shBENCHMARK_PHASE=init SEI_HOME=/tmp/test-bench/data benchmark/benchmark.shinits a chain in/tmp/test-bench/dataand exitsBENCHMARK_PHASE=start SEI_HOME=/tmp/test-bench/data LOG_FILE=/tmp/test.log benchmark/benchmark.shstarts seid using that data dirbenchmark/benchmark-compare.sh baseline=HEAD~1 candidate=HEADruns a full comparison using benchmark.sh for init/start🤖 Generated with Claude Code