[codex] fix giga snapshot storage rollback#3536
Draft
codchen wants to merge 1 commit into
Draft
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3536 +/- ##
==========================================
- Coverage 59.12% 58.26% -0.87%
==========================================
Files 2213 2140 -73
Lines 182774 174353 -8421
==========================================
- Hits 108072 101587 -6485
+ Misses 64985 63727 -1258
+ Partials 9717 9039 -678
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Giga used a single transaction cache plus explicit journal entries to undo store-backed writes. The same-value
SetStatepath intentionally wrote through without a storage journal entry, so a same-value SSTORE inside a reverted internal call could survive rollback as a dirty cache write. Value-writing rollback also left a dirty cache entry for non-noop storage changes, which can affect AppHash even when the visible EVM value is restored.Impact
Reverted EVM snapshots now discard store writes by dropping the snapshot cache layer, matching the V2 rollback model. Persistent store changes only flush from surviving snapshot layers during
Finalize, while the journal remains responsible for in-memory EVM state such as logs, refunds, transient storage, access lists, surplus, and account status markers.Validation
go test ./giga/deps/xevm/statego test ./giga/deps/xevm/...