This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Open
Conversation
v1.9.7
…oin_type_60_as_default
dssei
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
=======================================
Coverage 54.36% 54.36%
=======================================
Files 634 634
Lines 55600 55603 +3
=======================================
+ Hits 30226 30230 +4
+ Misses 23210 23209 -1
Partials 2164 2164
🚀 New features to boost your workflow:
|
dssei
requested review from
philipsu522,
sei-will and
stevenlanders
as code owners
sei-will
approved these changes
Aug 11, 2025
philipsu522
reviewed
Aug 11, 2025
client/keys/add.go
Outdated
| showMnemonic = false | ||
| mnemonic = "" | ||
| fmt.Fprintln(cmd.ErrOrStderr(), "\n**Important** Default coin type has been changed to ETH type 60. "+ | ||
| "Your address will be different if it was created with previous default ATOM coin type. "+ |
Contributor
There was a problem hiding this comment.
is this comment correct? does "ATOM" coin type make more sense or "118"
Collaborator
Author
There was a problem hiding this comment.
I think both are correct. Updated the wording to include ATOM(118), so both are mentioned.
codchen
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Update seid coin default type from ATOM (118) to ETH (60)
Testing performed to validate your change
seid