Skip to content

Pin Node.js 24 in release workflow #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codebycarson merged 1 commit into from
Feb 12, 2026
Merged

Pin Node.js 24 in release workflow #305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ jobs:
with:
fetch-depth: 0
submodules: recursive
- name: Setup Node.js

- name: Setup Node.js (for npm OIDC publishing)
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
node-version: '24'
registry-url: 'https://registry.npmjs.org'
Comment on lines +26 to 30
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release workflow now pins Node.js 24 while the rest of CI (e.g. checks.yml/coverage.yml) still uses .nvmrc (currently v20). This means the build+publish path can run on an untested Node major, which can lead to release-only failures or different build output. Consider aligning versions (update .nvmrc to 24, or switch other workflows to 24 / add a Node matrix including 24) so release runs on a version covered by CI.

Copilot uses AI. Check for mistakes.

- name: Install pnpm
Expand Down