Skip to content

CDP Mode: Patch 112 #4367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdmintz merged 2 commits into from
Jun 5, 2026
+8 −5
Merged

CDP Mode: Patch 112 #4367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9a7639
Fix `RuntimeWarning: coroutine 'Connection.aclose' was never awaited`
mdmintz Jun 5, 2026
c2973f3
Version 4.49.7
mdmintz Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion seleniumbase/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# seleniumbase package
__version__ = "4.49.6"
__version__ = "4.49.7"
11 changes: 7 additions & 4 deletions seleniumbase/undetected/cdp_driver/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,10 +916,13 @@ def stop(self, deconstruct=False):
close_success = False
try:
if self.connection:
asyncio.get_event_loop().create_task(self.connection.aclose())
logger.debug(
"Closed connection using get_event_loop().create_task()"
)
loop = asyncio.get_running_loop()
if loop.is_running():
loop.create_task(self.connection.aclose())
logger.debug("Closed connection with create_task()")
else:
loop.run_until_complete(self.connection.aclose())
logger.debug("Closed connection with run_until_complete()")
except RuntimeError:
if self.connection:
try:
Expand Down