Skip to content

CPLAT-9497: show task conversation in flat-mode preview#37

Merged
gavin-jeong merged 2 commits into
masterfrom
CPLAT-9497-conv-task-preview
May 11, 2026
Merged

CPLAT-9497: show task conversation in flat-mode preview#37
gavin-jeong merged 2 commits into
masterfrom
CPLAT-9497-conv-task-preview

Conversation

@gavin-jeong
Copy link
Copy Markdown
Collaborator

JIRA: https://sendbird.atlassian.net/browse/CPLAT-9497

Summary

  • Selecting a task in the flat conversation view previously rendered only
    a brief "Task: ... pending" summary on the right pane.
  • Now use the same rich preview path as tree mode so the actual task
    conversation entries are shown (matching the Tasks/Plan session preview).
  • Drop the now-unused renderTaskSummary helper.

Test plan

  • go build ./...
  • go vet ./...
  • go test ./... (passes)
  • Manual: open a session in flat conv view, move cursor onto a task line — confirm right pane shows the task's conversation entries instead of the brief summary.

Selecting a task in the flat conversation view previously rendered only
a brief Task summary on the right. Use the same rich preview path as
tree mode so the actual task conversation entries are shown.
The flat-mode task preview was rendering identical entries for every
task because the fallback path in extractTaskEntries used
strings.Contains over the raw ToolInput/Text JSON. With ordinal task
IDs ("1", "2", ... "10"), the substring check matched every
TaskCreate/TaskUpdate that happened to contain the digit.

- Compare the taskId JSON field exactly instead of substring matching.
- For pending tasks (no in_progress range), surface the originating
  TaskCreate via TaskCreate ordinal (the in-memory loader assigns IDs
  in creation order).
Copy link
Copy Markdown

@jinsekim jinsekim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown

@jinsekim jinsekim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gavin-jeong gavin-jeong merged commit efdd2f0 into master May 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants