feat(tasks)!: remove the tasks subpackage; relocate ENTSO-E CLI to spotforecast2.entsoe_cli#222
Merged
Conversation
…otforecast2.entsoe_cli The last tasks module, task_entsoe, is dissolved: - entsoe_data_loader / entsoe_test_data_loader now live in spotforecast2_safe.data.entsoe_loader (safe 22.3.0); the pin floor rises to >=22.3.0. - entsoe_lgbm_factory was body-identical to spotforecast2_safe.multitask.factories.default_lgbm_forecaster_factory and is dropped in favour of the safe original. - The CLI (main, entsoe_xgb_factory, pipeline plumbing) moves to spotforecast2.entsoe_cli; the spotforecast2-entsoe console script is unchanged in name and behaviour. - bart26k-lecture migrated its 8 import sites ahead of this change (commit 1df90d3 there); the team4 consumer-contract gate passes 4/4 against the updated qmd. - docs/tasks/entsoe.qmd loses two sections that documented the legacy ForecasterRecursiveLGBM/XGB wrapper API removed back in ADR-002; they are rewritten around the current factory + MultiTask pipeline. BREAKING CHANGE: the spotforecast2.tasks subpackage is removed. Import the data loaders from spotforecast2_safe.data.entsoe_loader, the LightGBM factory from spotforecast2_safe.multitask.factories, and the CLI module as spotforecast2.entsoe_cli. The spotforecast2-entsoe console script is unaffected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
🎉 This PR is included in version 10.0.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Collaborator
Author
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final step of the
spotforecast2.tasksremoval (KBtask-sf2-task-entsoe-extraction). The last module,task_entsoe, is dissolved:spotforecast2_safe.data.entsoe_loader(released in safe 22.3.0, PR spotforecast2-safe#371); sf2's pin floor rises to>=22.3.0,<23entsoe_lgbm_factorywas body-identical tospotforecast2_safe.multitask.factories.default_lgbm_forecaster_factory→ dropped in favour of the safe originalmain,entsoe_xgb_factory, pipeline plumbing) → newspotforecast2.entsoe_climodule; thespotforecast2-entsoeconsole script keeps its name and behaviour1df90d3on its master, incl. the protected14_team_4_submission.qmd)docs/tasks/entsoe.qmd: two sections still documenting the legacyForecasterRecursiveLGBM/XGBwrapper API (removed in ADR-002) are rewritten around the current factory + MultiTask pipelineBreaking change
spotforecast2.tasksis removed → next promotion majors to 10.0.0. Consumers unaffected: lecture pins<9and no longer imports tasks; abschluss uses only MultiTask + safe symbols.Verification
uv run pytest tests/ -q— 1247 passed, incl.test_consumer_contract_team4.py4/4 against the migrated qmd with tasks/ deletedquarto render --no-cache— green, zero warnings;_sitehasentsoe_cli.html, notasks.*pagesuv run spotforecast2-entsoe --helpworks;import spotforecast2.tasks→ModuleNotFoundError🤖 Generated with Claude Code