test(tricands): close leaked figures before each test#100
Merged
Conversation
test_visualization_2d mocks plt.figure, so tricands draws into whatever Axes gca() finds. Under pytest-xdist a 3D Axes leaked by an earlier test on the same worker makes scatter raise 's must be a scalar, or float array-like with the same size as x and y' (seen on CI run 27290133117). Close all figures in setup_method so the test owns its pyplot state. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky
test_visualization_2dfailure on CI (run 27290133117, blocking release PR #99): the test mocksplt.figure, sotricands(vis=True)draws into whatever Axesgca()finds — under pytest-xdist that can be a 3D Axes leaked by an earlier test on the same worker, andAxes3D.scatterthen raisesValueError: s must be a scalar.... Reproduced locally by pre-creating a 3D axes; fixed byplt.close('all')insetup_method.🤖 Generated with Claude Code