feat(mm): add plot_only_corrected flag + ignore-list merge + flake fix#78
Merged
Conversation
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
Resolved. I merged |
When True, the function plots only the corrected Morris-Mitchell criterion on a single axis instead of the dual-axis comparison with the intensive criterion. Default remains False for backward compatibility. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The assertion intent is "the loop terminated", not a tight timing budget. Shared CI runners occasionally stall the parallel pool teardown by several seconds, producing spurious failures (latest observed: 10.44s on a 10.0s ceiling for a 3s max_time target). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bartzbeielstein
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
developforward onto the post-Dependabotmain, plus three small changes that accumulated ondevelop:2f6ec27aaca3adplot_only_corrected: bool = Falsetoplot_mmphi_corrected_vs_n_lhs. WhenTrue, plot only the corrected criterion on a single axis instead of the dual-axis intensive/corrected comparison. Two new tests cover the flag and the default behaviour.c755315test_parallel_max_timeceiling from< 10sto< 20sto stop CI runners blowing through it during pool teardown. The lower bound (>= 2.5s) is unchanged, so the test still validates thatmax_timeis honoured.The previous CI run on this PR failed solely on the flaky timing assertion that
c755315now widens.Test plan
test_parallel_max_timepasses locally in 6.91 s under the new ceiling.🤖 Generated with Claude Code