Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

Pass through cloudfront.origins inputs and expand relative paths#376

Merged
danielcondemarin merged 1 commit into
serverless-nextjs:masterfrom
HeroTeamLdn:pass-origins
May 1, 2020
Merged

Pass through cloudfront.origins inputs and expand relative paths#376
danielcondemarin merged 1 commit into
serverless-nextjs:masterfrom
HeroTeamLdn:pass-origins

Conversation

@gehan

@gehan gehan commented May 1, 2020

Copy link
Copy Markdown
Contributor

Allows you to pass origins to aws-cloudfront as well as setting headers for api and defaults etc.

We do this commonly for redirects and also for legacy parts of sites that request static from particular urls.

@janoist1

janoist1 commented May 1, 2020

Copy link
Copy Markdown

+1

@gehan gehan closed this May 1, 2020
@gehan gehan reopened this May 1, 2020
@danielcondemarin

Copy link
Copy Markdown
Contributor

@gehan Thanks for implementing this! It is a great simple api addition.

Just one thing, could you update the README page?

@danielcondemarin

danielcondemarin commented May 1, 2020

Copy link
Copy Markdown
Contributor

@gehan Thanks for implementing this! It is a great simple api addition.

Just one thing, could you update the README page?

Nevermind just noticed it is covered already. Merging 🚀

@danielcondemarin danielcondemarin merged commit 69beb5a into serverless-nextjs:master May 1, 2020
@gehan

gehan commented May 1, 2020

Copy link
Copy Markdown
Contributor Author

Yeah no worries! Always good to PR changes back.

I've also patched aws-cloudfront too in case you are active on that too - serverless-components/aws-cloudfront#19

I'll probably have another PR soon for something else :D

@alexrosano

Copy link
Copy Markdown

Thanks for getting this in! This is exactly what we were looking to do.

@alexrosano

Copy link
Copy Markdown

@gehan when will this be released?

@gehan

gehan commented May 1, 2020

Copy link
Copy Markdown
Contributor Author

@alexrosano not up to me! i'm just using this for a project i'm doing

I published this to npm for the moment though so it can be used as @heroteam/serverless-next.js

It was private for some reason and just changed it to public

@alexrosano

Copy link
Copy Markdown

awesome thank u

@danielcondemarin

danielcondemarin commented May 1, 2020

Copy link
Copy Markdown
Contributor

Hi folks, I've just published this in serverless-next.js@1.11.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants