Skip to content

SES-2568 : Prevent triggering the app version check on test build#1969

Open
jbsession wants to merge 3 commits intodevfrom
improvements/version-check
Open

SES-2568 : Prevent triggering the app version check on test build#1969
jbsession wants to merge 3 commits intodevfrom
improvements/version-check

Conversation

@jbsession
Copy link
Collaborator

Added a build config value CHECK_VERSION. Set to false on automaticQa build.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably shouldn't let QA builds trigger the check either.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also disable it for debug

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah ideally only prod builds would do the check for the best stats

@SessionHero01
Copy link
Collaborator

Well we should really only enable it for release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments