src/passwd.c: add audit messages for passwd#1533
Merged
ikerexxe merged 2 commits intoshadow-maint:masterfrom Feb 13, 2026
Merged
src/passwd.c: add audit messages for passwd#1533ikerexxe merged 2 commits intoshadow-maint:masterfrom
ikerexxe merged 2 commits intoshadow-maint:masterfrom
Conversation
ikerexxe
force-pushed
the
passwd-audit
branch
from
95d096c to
f67587c
Compare
ikerexxe
force-pushed
the
passwd-audit
branch
from
f67587c to
8f962a9
Compare
Add comprehensive audit messages for password operations, including unlock, delete and expire operations. Change update_shadow() to look up the actual target user instead of using a dummy `passwd` struct. This ensures audit logging gets the correct target UID. Audit logs should record the UID of the user being affected (target), not the UID of whoever is running the passwd command (source). Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
ikerexxe
force-pushed
the
passwd-audit
branch
from
8f962a9 to
a5a00bf
Compare
alejandro-colomar
approved these changes
Feb 13, 2026
Collaborator
|
LGTM. I didn't check it thoroughly, as I'm starting to have fever, and my brain isn't ready for that, but feel free to commit. We could fix it later if it has any issues. It looks reasonably good. |
Collaborator
Author
Take care Alejandro! There are a lot of viruses going around these days, so I hope it's nothing serious |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive audit messages for password operations, including unlock, delete, expire and aging operations.