Vendor full tokenized WikiText-2 corpus into core benchmark fixtures#27
Vendor full tokenized WikiText-2 corpus into core benchmark fixtures#27sharpninja merged 9 commits intomainfrom
Conversation
Co-authored-by: sharpninja <16146732+sharpninja@users.noreply.github.com> Agent-Logs-Url: https://github.com/sharpninja/BitNet-b1.58-Sharp/sessions/7c44e2cd-8fbf-4adf-ae05-635ca9ee4080
Co-authored-by: sharpninja <16146732+sharpninja@users.noreply.github.com> Agent-Logs-Url: https://github.com/sharpninja/BitNet-b1.58-Sharp/sessions/7c44e2cd-8fbf-4adf-ae05-635ca9ee4080
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR vendors the full pre-tokenized WikiText-2 corpus into BitNetSharp.Core as embedded resources and updates benchmark fixtures/tests/docs so benchmark/audit paths use repository-local data without external downloads.
Changes:
- Embed
wiki.train/valid/test.tokensintoBitNetSharp.Coreand load them viaBitNetBenchmarkFixtures. - Expand fixture surface with split-specific properties (train/valid/test) and keep perplexity wired to validation.
- Add tests to validate split loading/counts and update benchmarking docs to reflect the new local corpus source.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/BitNetSharp.Tests/HostedAgentBenchmarksExecutionTests.cs | Uses a smaller validation subset for perplexity test runtime; adds split-loading assertions for the new fixtures. |
| src/BitNetSharp.Core/BitNetSharp.Core.csproj | Embeds the vendored WikiText-2 token files as resources. |
| src/BitNetSharp.Core/BitNetBenchmarkFixtures.cs | Replaces placeholder WikiText-2 data with lazy-loaded embedded-resource splits. |
| docs/benchmarking.md | Documents that benchmark perplexity now uses the vendored local WikiText-2 validation split. |
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: sharpninja <16146732+sharpninja@users.noreply.github.com> Agent-Logs-Url: https://github.com/sharpninja/BitNet-b1.58-Sharp/sessions/cb4f0c8e-263a-48fc-875c-3ccea7631ebe
Co-authored-by: sharpninja <16146732+sharpninja@users.noreply.github.com> Agent-Logs-Url: https://github.com/sharpninja/BitNet-b1.58-Sharp/sessions/cb4f0c8e-263a-48fc-875c-3ccea7631ebe
Addressed in 679d00d. The WikiText-2 loader now preserves blank separator rows line-for-line, the fixture tests use shorter stable assertions instead of full long literals, and the benchmarking docs were updated to match the actual in-memory behavior. |
|
@copilot diagnose and fix test failures in build pipeline. |
Co-authored-by: sharpninja <16146732+sharpninja@users.noreply.github.com> Agent-Logs-Url: https://github.com/sharpninja/BitNet-b1.58-Sharp/sessions/efe42022-8a61-4408-89ff-da2ae67c2259
Co-authored-by: sharpninja <16146732+sharpninja@users.noreply.github.com> Agent-Logs-Url: https://github.com/sharpninja/BitNet-b1.58-Sharp/sessions/efe42022-8a61-4408-89ff-da2ae67c2259
Addressed in 527f9df. I traced the pipeline issue to the |
Co-authored-by: sharpninja <16146732+sharpninja@users.noreply.github.com> Agent-Logs-Url: https://github.com/sharpninja/BitNet-b1.58-Sharp/sessions/b27c3cde-6893-4c19-866c-09f79c5acb7c
Co-authored-by: sharpninja <16146732+sharpninja@users.noreply.github.com> Agent-Logs-Url: https://github.com/sharpninja/BitNet-b1.58-Sharp/sessions/b27c3cde-6893-4c19-866c-09f79c5acb7c
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.