forked from shipshapecode/starpod
-
Notifications
You must be signed in to change notification settings - Fork 0
Pare sponsor offerings to 4 tiers and raise pricing ~1.75x #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RobbieTheWagner
wants to merge
1
commit into
main
Choose a base branch
from
sponsor-page-4-tiers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−49
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default
ctaHrefwill produce an invalid URL whenproductIdis undefined.Line 19 constructs the default
ctaHrefas`/api/checkout?products=${productId}`. SinceproductIdis now optional (line 6), when it's undefined the URL becomes/api/checkout?products=undefined, which will fail at the Polar checkout endpoint. The Single Barrel tier (which omitsproductId) works because it provides its ownctaHref, but this default is fragile and could break future cards that omitproductIdwithout providingctaHref.Guard the template literal or make the logic explicit.
🛡️ Proposed fix to guard against undefined productId
const { bullets, heading, price, productId, period = 'per episode', ctaLabel = 'Become a sponsor', - ctaHref = `/api/checkout?products=${productId}` + ctaHref = productId ? `/api/checkout?products=${productId}` : '#' } = Astro.props;Alternatively, if a
ctaHrefis always expected whenproductIdis omitted, add a runtime check or TypeScript constraint to enforce the mutual dependency.📝 Committable suggestion
🤖 Prompt for AI Agents